Skip to content

WIP: ✨ feat: Support Access Entries #5583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

WIP: ✨ feat: Support Access Entries #5583

wants to merge 20 commits into from

Conversation

joshfrench
Copy link

What type of PR is this?
/kind feature

What this PR does / why we need it:

Adds support for configuring access entries, which is now the preferred way to manage IAM access to EKS clusters.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4854

Special notes for your reviewer:
Depends on #5578, and so includes a bunch of commits from that PR. I can hold this PR and rebase once that's merged if it makes it easier to review this, but wanted to open for visibility ASAP.

Checklist:

  • squashed commits
  • includes documentation
  • includes emoji in title
  • adds unit tests
  • adds or updates e2e tests

Release note:

Add support for configuring cluster IAM permissions via Access Entries

adammw and others added 20 commits September 5, 2024 16:09
@adammw
feat: support setting EKS AuthenticationMode
904ed61
@adammw
Add GCFLAGS
fe7b9a9
@adammw
Add debug log line
f36e389
@adammw
Add webhook validation for access config
49e7a7b
@adammw
add unit tests
3e5754c
@adammw
Make revive happy on naming
c192252
@adammw
fix failing test with invalid mocked input
e2353cd
@adammw
add accessConfig to v1beta1 type as well
62e4137
@joshfrench
Revert "add accessConfig to v1beta1 type as well"
39b209c 
This reverts commit 62e4137.
@joshfrench
preserve AccessConfig during AWSManagedControlPlane API conversions
4fdb6c2
@joshfrench
Merge branch 'main' into auth-config
bf1e05e
@joshfrench
cruft
7a73ff7
@mdbooth @joshfrench
Create multiple control plane loadbalancers concurrently
c8573f7
@punkwalker @damdo @joshfrench
🌱 Migrate ServiceLimiters to AWS SDK V2 (kubernetes-sigs#5574)
a1c815a 
* Migrate ServiceLimiters to AWS SDK V2

Signed-off-by: Pankaj Walke <[email protected]>

* fix lint errors

Signed-off-by: Pankaj Walke <[email protected]>

* makefile: bump release-binaries's GOMAXPROCS=2

it was hanging otherwise

---------

Signed-off-by: Pankaj Walke <[email protected]>
Co-authored-by: Damiano Donati <[email protected]>
@joshfrench
Add AccessEntry to AWSManagedControlPlane API
bbfc6de
@joshfrench
validations for awsmanagedcontrolplane accessentries
2db5348
@joshfrench
Tests for AccessEntry validations
75adc15
@joshfrench
Adds support for reconciling EKS AccessEntries
c081d31
@joshfrench
tests for access entry reconciliation
19a93ed
@joshfrench
e2e tests for access entries
d7cf41b
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels Jul 3, 2025
@k8s-ci-robot
Copy link
Contributor

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot requested review from nrb and richardcase July 3, 2025 16:55
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ankitasw for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 3, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @joshfrench. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@joshfrench joshfrench mentioned this pull request Jul 7, 2025
Open
5 tasks
@joshfrench joshfrench mentioned this pull request Jul 19, 2025
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrb nrb Awaiting requested review from nrb

@richardcase richardcase Awaiting requested review from richardcase

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/contains-merge-commits do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support AccessEntry configuration for IAM Authentication of EKS clusters
5 participants
@joshfrench @k8s-ci-robot @adammw @mdbooth @punkwalker